httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: Thread safety of SSLRequire?
Date Tue, 26 Apr 2005 06:28:02 GMT
On Mon, Apr 25, 2005 at 03:58:46PM -0700, Paul Querna wrote:
> Look at:
> http://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl/ssl_expr.c
> 
> It has two globals:
> ssl_expr_info_type ssl_expr_info;
> char              *ssl_expr_error;
> 
> Which are used inside the ssl_expr_comp(), which is called from
> ssl_cmd_SSLRequire().
> 
> SSLRequire can be put in an .htaccess file.
> 
> Wouldn't this mean in a threaded MPM, that two threads could easily be
> parsing .htaccess files at the same time, and both enter ssl_expr_comp,
> which uses those globals... kaboom?

Yup, it's one of the long-standing mod_ssl TODO items Doug noted now in
STATUS.  I believe you have to go to some effort but flex and bison will
produce C code which doesn't use global state - that's probably the hard
part in fixing this.

joe

Mime
View raw message