httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: For review: teach mod_include.c to recycle brigades
Date Mon, 25 Apr 2005 21:27:30 GMT
* Rici Lake wrote:

+1 in general, but ...

> Index: mod_include.h
> ===================================================================
> --- mod_include.h       (revision 158730)
> +++ mod_include.h       (working copy)
> @@ -85,6 +85,9 @@
>       /* currently configured time format */
>       const char  *time_str;
>
> +    /* bucket brigade for passing to next filter */
> +    apr_bucket_brigade *pass_bb;
> +
>       /* pointer to internal (non-public) data, don't touch */
>       struct ssi_internal_ctx *intern;
>   } include_ctx_t;

...put it into the internal structure, please. That's I've created it for 
(binary compat and only making stuff public what matters the public).

nd
-- 
>>> Muschelflucht-Zusatzeinrichtung.
>> Shell-Escape ist ja noch klar, aber `Zusatzeinrichtung'?
> extension?
Feature.                          -- gefunden in de.org.ccc

Mime
View raw message