httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: [PATCH] mod_cache, expand impact of CacheIgnoreCacheControl
Date Wed, 09 Mar 2005 18:57:06 GMT
--On Wednesday, March 9, 2005 7:42 PM +0200 Eli Marmor <marmor@netmask.it> 
wrote:

> That's all?!
>
> Let me quote myself (and this is not the complete list):
>
>> If I recall correctly, there were MANY conditions in mod_cache that
>> prevented caching (like checking for a POST method, no-store, no-cache,
>> auth, GET args, private, public, must-revalidate, maxage, etc.).
>
> The complete list may be long, but if we want to allow offline caching,
> we must precede a condition before any rule of mod_cache.c that
> prevents caching in any case, and I don't see any serious difference
> (performance, code size, memory size) between "if (conf->something!=0)"
> and "if (conf->something & SOMETHING != 0)". So we don't need to have
> one directive/bit for many conditions, as long as it is done in a
> friendly way for the users (i.e. there are 3-4 pre-defined constants
> which mean "cache nothing", "default cache", and "cache everything -
> for offline browsing").

As you know, we don't currently have directives for most of these items. 
We can gradually add them.

However, to make your patch easier to review, I'd suggest taking it 
piecemeal - convert the current binary options to a CacheOptions directive 
and then once that is complete and accepted in the tree, we can then add 
new options one at a time.  We like smaller and easier-to-review patches. 
=)

Does this make sense?  -- justin

Mime
View raw message