httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <br...@xbc.nu>
Subject [PATCH] Fix mod_dav exports on Windows
Date Wed, 23 Feb 2005 02:07:15 GMT
A number of public functions in mod_dav.h aren't properly exported with 
DAV_DECLARE. This recently became a problem for Subversion, because 
mod_dav_svn now supports DAV locking, and mod_dav's locking functions 
were amongst the ones that were not exported. Nobody noticed this on 
Unix where DAV_DECLARE is a no-op, but Windows suffered mightily.

The attached patch (against the 2.0.x branch) fixes the problem. I had 
to use DAV_DECLARE_NONSTD in a few places where the functions are used 
as callbacks, because I didn't want to fiddle with the __stdcall horror 
in callback parameter declarations.

Subversion 1.2, which will introduce locking functionality, will not 
work as a DAV server on Windows without an httpd-2.0.x release that 
includes this patch. I hope such a thing is possible in the next few 
months, and I'm only sorry I was too late for the the 2.0.53 release.

[[[
Correctly export all mod_dav public functions.

* modules/dav/main/mod_dav.h: Wrap all public functions in
  DAV_DECLARE or DAV_DECLARE_NONSTD.
* modules/dav/main/liveprop.c, modules/dav/main/props.c,
  modules/dav/main/util_lock.c, modules/dav/main/mod_dav.c,
  modules/dav/main/std_liveprop.c, modules/dav/main/util.c:
  Update function definitions.
]]]


-- Brane


Mime
View raw message