httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: [PATCH] Log 408
Date Thu, 17 Feb 2005 18:51:24 GMT
* Jim Jagielski wrote:

> Another set of eyes please :)
>
> Index: server/protocol.c
> ===================================================================
> --- server/protocol.c   (revision 153271)
> +++ server/protocol.c   (working copy)
> @@ -880,6 +880,12 @@
>               return r;
>           }
>
> +        if (r->status == HTTP_REQUEST_TIME_OUT &&
> r->connection->keepalive != AP_CONN_KEEPALIVE) {
> +            r->the_request = "";
> +            ap_update_child_status(conn->sbh, SERVER_BUSY_LOG, r);
> +            ap_run_log_transaction(r);
> +        }
> +
>           apr_brigade_destroy(tmp_bb);
>           return NULL;
>       }

Unfortunately this also logs SSL handshake errors and aborted connections as 
408, which is not correct. I'd log this as a more general error (400?, 
0? ), but not as time out.

nd
-- 
package Hacker::Perl::Another::Just;print
qq~@{[reverse split/::/ =>__PACKAGE__]}~;

#  André Malo  #  http://www.perlig.de  #

Mime
View raw message