httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ronald Park <r...@cnet.com>
Subject Re: re-do of proxy request body handling - ready for review
Date Wed, 02 Feb 2005 17:32:39 GMT
I was recently considering a similar patch for mod_proxy along the lines
of spool_reqbody_cl() method but it would go one step further: spawning
off a thread to asynchronously read the request into a temp file (or
files) while the initial thread would continue to stream the io_bufsize
chunks down the filter chain. This would 'untie' the original client
and the proxy server in cases where they ran at different speeds (more
a problem for *large* proxy files where one side or the other could be
tied up waiting for the slower side for long periods of time... and
poor Apache caught in the middle).

I hadn't gotten too far along with my patch but with this, it's about
90% of the way done. :)

Ron

On Wed, 2005-02-02 at 09:56 -0500, Greg Ames wrote:
> Jeff Trawick wrote:
> > Please review the proxy-reqbody branch for proposed improvements to
> > 2.1-dev.  There is a 2.0.x equivalent of the patch at
> > http://httpd.apache.org/~trawick/20proxyreqbody.txt.
> 
> +1 (reviewed, not tested)
> 
> certainly an improvement over what we have today.  The brains (decisions about 
> what to do with a body) are nicely isolated to a few lines of code in 
> send_request_body().  The rest of it is the muscle, and that shouldn't be 
> controversial...either it works or it doesn't, and I can't spot any problems.
> 
> Greg
> 
-- 
Ronald Park <ronp@cnet.com>


Mime
View raw message