Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: neutral (hermes.apache.org: local policy)
Message-ID: <41AB7287.7050201@apache.org>
Date: Mon, 29 Nov 2004 20:03:35 +0100
From: Mladen Turk <mturk@apache.org>
User-Agent: Mozilla
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: svn commit: r106843 -  /httpd/httpd/trunk/include/ap_listen.h
  /httpd/httpd/trunk/server/listen.c
References: <20041128193742.20627.qmail@minotaur.apache.org>
 <41AAF06D.3060305@apache.org> <52A15D37E9A871557ED3B56C@[10.0.1.13]>
 <6.2.0.14.2.20041129113440.052f58d0@pop3.rowe-clan.net>
In-Reply-To: <6.2.0.14.2.20041129113440.052f58d0@pop3.rowe-clan.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

William A. Rowe, Jr. wrote:
> 
> The reason this popped up is that the function was not
> previously exported, therefore it was in the c convention
> as a local function.
> 
> In the future, Mladen, please don't assume unix coders know
> this distinction and please go ahead, fix things up as necessary.

Have no idea how to do that with AP_DECLARE.
So either declarations inside ap_listen.h will change to something
that is acceptable on all platforms, or we'll be unable to build
on win32 anymore AFAICT.

Only thing that I can think of is to add new proto
AP_DECLARE_STD that will be declared as:
#define AP_DECLARE_STD(type)            type

and adding that to make_exports.awk
/^[ \t]*AP[RU]?_(CORE_)?DECLARE?(_STD)[^(]*[(][^)]*[)]([^ ]* )*[^(]+[(]/ {
     sub("[ \t]*AP[RU]?_(CORE_)?DECLARE?(_STD)[^(]*[(][^)]*[)][ \t]*", "")


> Platform maintainers accept that folks will break code on their 
> platform - it's a given.
> 

I'm aware of that. Just fixed couple of things related to mod_cache
and pcre.


MT.