httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: [PATCH] add ap_brigade_insert_file()
Date Fri, 05 Nov 2004 06:34:50 GMT
--On Thursday, November 4, 2004 10:07 PM +0000 Joe Orton <jorton@redhat.com> 
wrote:

> This factors out the logic for correctly inserting a file into a
> brigade, doing the special little dance for large files if necessary;
> the code was already duplicated twice and it's needed in other places
> too.  (pervasive largefile support being my top 2.1 goal :)

*nod*

> Any comments, naming preferences, "put it in apr-util you twit" flames?

"Put it in apr-util, you marvelous angel."  Pretty please with sugar on top...

Looks fine otherwise... =)  -- justin

Mime
View raw message