httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Stoddard <b...@wstoddard.com>
Subject Re: [PATCH] CAN-2004-0942 fix
Date Thu, 04 Nov 2004 02:33:48 GMT
Joe Orton wrote:
> On Wed, Nov 03, 2004 at 01:39:20PM -0500, Bill Stoddard wrote:
> 
>>Joe Orton wrote:
>>
>>
>>>+    /* Now NUL-terminate the string at the end of the line; 
>>>+     * if the last-but-one character is a CR, terminate there */
>>>+    if (last_char > *s && last_char[-1] == APR_ASCII_CR) {
>>
>>last_char[-1]... yack, that's just nasty syntax if you ask me.
> 
> 
> Succinct and easier to parse than *(last_char - 1) if you ask me...
> 

Kept getting interrupted, but +1 for the patch. I don't personally care for the last_char[-1]
syntax, but 
that's just my preference.

Bill

Mime
View raw message