httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] another mod_deflate vs 304 response case
Date Mon, 22 Nov 2004 17:02:43 GMT
On Mon, Nov 22, 2004 at 11:26:18AM -0500, Cliff Woolley wrote:
> On Mon, 22 Nov 2004, Joe Orton wrote:
> 
> > There's another mod_deflate vs 304 response problem which is being
> > triggered by ViewCVS on svn.apache.org: when a CGI script gives a
> > "Status: 304" response the brigade contains a CGI bucket then the EOS,
> > so fails the "if this brigade begins with EOS do nothing" test added for
> > the proxied-304 case.
> >
> > I wonder if the simplest fix is to just explicitly test for a 304/204
> > response instead.  Were there any more EOS-only brigade cases this won't
> > catch?
> 
> Okay, but why the next three lines?  Why would Content-Encoding: gzip
> *ever* be set on a 304?

I was wondering that too.  The answer to the latter is that it *won't*
be sent for a 304 because the http_header filter knows better than that.

joe


Mime
View raw message