httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thom May <>
Subject Re: [PATCH] add ap_brigade_insert_file()
Date Thu, 04 Nov 2004 22:27:18 GMT
* Joe Orton ( wrote :
> This factors out the logic for correctly inserting a file into a
> brigade, doing the special little dance for large files if necessary;
> the code was already duplicated twice and it's needed in other places
> too.  (pervasive largefile support being my top 2.1 goal :)
> Any comments, naming preferences, "put it in apr-util you twit" flames?
I suspect I'd like to see it in apr-util, but I'd hesitate to call you a
twit :-)
(and change the name accordingly)
Otherwise, looks good.

View raw message