Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Message-ID: <418252E0.3040308@wstoddard.com>
Date: Fri, 29 Oct 2004 10:25:36 -0400
From: Bill Stoddard <bill@wstoddard.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
 rv:1.7.3) Gecko/20040910
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: [PATCH] ap_log_cerror()
References: <cc67648e04102904075d76532e@mail.gmail.com>
In-Reply-To: <cc67648e04102904075d76532e@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Jeff Trawick wrote:
> I'm gonna puke if I see another connection-oriented error message with
> no client IP.
> 
> Am I missing something basic, or is there really no reason NOT to have
> ap_log_cerror()?  It seems so obvious.
> 
> before: 
> [Fri Oct 29 06:56:16 2004] [info] (32)Broken pipe: core_output_filter:
> writing data to the network
> 
> after: 
> [Fri Oct 29 06:56:54 2004] [info] [client 192.168.1.128] (32)Broken
> pipe: core_output_filter: writing data to the network
> 
> There are probably a number of other places where this can be applied,
> and of course I need to add doc to http_log.h, but this is my sanity
> check that somebody here knows something that google doesn't.

+1

Bill