httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <>
Subject Re: cvs commit: httpd-2.0/server core.c protocol.c request.c scoreboard.c util.c util_script.c
Date Mon, 25 Oct 2004 16:28:08 GMT
   mod_cache is a different issue.  The compiler used to build the
netware NLMs is very sensitive to type mismatches.  

>   @@ -3793,7 +3794,7 @@
>        core_net_rec *net = f->ctx;
>        core_ctx_t *ctx = net->in_ctx;
>        const char *str;
>   -    apr_size_t len;
>   +    apr_ssize_t len;

Changing the type from apr_size_t to apr_ssize_t introduced a type
mismatch in the call to apr_bucket_read() which expects an apr_size_t. 
Type casting it back to an apr_size_t to fix the problem seems like it
would have defeated the whole purpose of doing it in the first place. 
Besides the fact that apr_bucket_read() can't give you back anything
bigger than an apr_size_t anyway.


>>> Monday, October 25, 2004 10:01:53 AM >>>
Brad Nicholes wrote:
> -1 as well.  This is now causing compiler errors on NetWare.  Please
> revert this patch!

Can you provide an indication of exactly what broke so we
will know what to avoid in future. Or was the breakage
actually due to the the mod_cache problem reported
last night?

Thanks, Allan

View raw message