httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Garrett Rooney <roo...@electricjellyfish.net>
Subject Re: Mod_Cache build problem on NetWare...
Date Mon, 25 Oct 2004 22:02:51 GMT
Jean-Jacques Clar wrote:
> What about doing:
>  
>  static const char *add_ignore_header(cmd_parms *parms, void *dummy,
> -                                     const char *header)
> +                                     char *header)
>  {
>      cache_server_conf *conf;
>      char **new;
> @@ -802,7 +802,7 @@
>               * (When 'None' is passed, IGNORE_HEADERS_SET && nelts == 0.)
>               */
>              new = (char **)apr_array_push(conf->ignore_headers);
> -            (*new) = (char *)header;
> +            (*new) = header;
> 

That seems fine, the only reason I didn't suggest it was that I wasn't 
sure if we were ever passing anything const in as an argument, if we 
aren't then just making header non-const should clean up the problem 
nicely without the cast.

-garrett

Mime
View raw message