httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject Re: mod_proxy broke RewriteRule ... [P]
Date Thu, 14 Oct 2004 19:38:05 GMT
just in case this fell through the cracks, does anyone have any ideas?

--Geoff

Joe Orton wrote:
> Noticed first in the mod_perl tests, but this is an equivalent repro
> case.  mod_proxy in HEAD no longer allows modules to set r->handler =
> "proxy-server" and force a request to be proxied (when ProxyRequests is 
> not set, and no ProxyPass's are configured).
> 
> ap_proxy_pre_request enters with conf->forward == NULL, *balancer ==
> NULL, and so returns DECLINED.  Can this be fixed somehow?  Mladen?
> 
> ----- Forwarded message from jorton@apache.org -----
> 
> From: jorton@apache.org
> Reply-To: test-dev@httpd.apache.org
> To: httpd-test-cvs@apache.org
> Date: 12 Oct 2004 13:53:41 -0000
> Subject: cvs commit: httpd-test/perl-framework/t/conf extra.conf.in
> 
> jorton      2004/10/12 06:53:41
> 
>   Modified:    perl-framework/t/modules rewrite.t
>                perl-framework/t/conf extra.conf.in
>   Log:
>   Add test for RewriteRule [P] flag which is broken in HEAD
>   due to mod_proxy changes.
>   
>   Revision  Changes    Path
>   1.11      +9 -1      httpd-test/perl-framework/t/modules/rewrite.t
>   
>   Index: rewrite.t
>   ===================================================================
>   RCS file: /home/cvs/httpd-test/perl-framework/t/modules/rewrite.t,v
>   retrieving revision 1.10
>   retrieving revision 1.11
>   diff -d -w -u -r1.10 -r1.11
>   --- rewrite.t	4 Aug 2004 15:44:09 -0000	1.10
>   +++ rewrite.t	12 Oct 2004 13:53:41 -0000	1.11
>   @@ -14,7 +14,7 @@
>    my @url = qw(forbidden gone perm temp);
>    my $r;
>    
>   -plan tests => @map * @num + 3, need_module 'rewrite';
>   +plan tests => @map * @num + 4, need_module 'rewrite';
>    
>    foreach (@map) {
>        foreach my $n (@num) {
>   @@ -52,3 +52,11 @@
>    chomp $r;
>    $r =~ s/\r//g;
>    ok ($r eq "JACKPOT");
>   +
>   +if (have_module('mod_proxy')) {
>   +    $r = GET_BODY("/modules/rewrite/proxy.html");
>   +    chomp $r;
>   +    ok t_cmp($r, "JACKPOT", "request was proxied");
>   +} else {
>   +    skip "Skipping rewrite to proxy; no proxy module.";
>   +}
>   
>   
>   
>   1.52      +3 -0      httpd-test/perl-framework/t/conf/extra.conf.in
>   
>   Index: extra.conf.in
>   ===================================================================
>   RCS file: /home/cvs/httpd-test/perl-framework/t/conf/extra.conf.in,v
>   retrieving revision 1.51
>   retrieving revision 1.52
>   diff -d -w -u -r1.51 -r1.52
>   --- extra.conf.in	20 Sep 2004 19:28:47 -0000	1.51
>   +++ extra.conf.in	12 Oct 2004 13:53:41 -0000	1.52
>   @@ -157,6 +157,9 @@
>            RewriteCond %{ENV:MAPTYPE} =prg
>            RewriteRule ^([1-6])$ ${numbers-prg:$1}.html [L]
>    
>   +        ## Proxy pass-through
>   +        RewriteRule ^proxy.html$ http://@SERVERNAME@:@PORT@/modules/rewrite/lucky13.html
[L,P]
>   +
>        </Directory>
>    </IfModule>
>    
>   
>   
>   
> 
> ----- End forwarded message -----

Mime
View raw message