httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: cvs commit: httpd-2.0/modules/mappers mod_rewrite.c
Date Thu, 14 Oct 2004 07:10:32 GMT
On Wed, Oct 13, 2004 at 05:23:12PM -0000, minfrin@apache.org wrote:
>   --- mod_rewrite.c	13 Oct 2004 17:12:09 -0000	1.135.2.32
>   +++ mod_rewrite.c	13 Oct 2004 17:23:12 -0000	1.135.2.33
>   @@ -1477,9 +1477,17 @@
>         *  remember the current filename before rewriting for later check
>         *  to prevent deadlooping because of internal redirects
>         *  on final URL/filename which can be equal to the inital one.
>   +     *  also, we'll restore original r->filename if we decline this
>   +     *  request
>         */
>        ofilename = r->filename;
>    
>   +    if (r->filename == NULL) {
>   +        r->filename = apr_pstrdup(r->pool, r->uri);
>   +        rewritelog((r, 2, "init rewrite engine with requested uri %s",
>   +                    r->filename));
>   +    }
>   +

Nobody tried even compiling this one I guess :(

mod_rewrite.c: In function `hook_fixup':
mod_rewrite.c:1488: too few arguments to function `rewritelog'

can I get some votes for:

Index: modules/mappers/mod_rewrite.c
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/mappers/mod_rewrite.c,v
retrieving revision 1.135.2.33
diff -u -r1.135.2.33 mod_rewrite.c
--- modules/mappers/mod_rewrite.c	13 Oct 2004 17:23:12 -0000	1.135.2.33
+++ modules/mappers/mod_rewrite.c	14 Oct 2004 07:03:33 -0000
@@ -1484,8 +1484,8 @@
 
     if (r->filename == NULL) {
         r->filename = apr_pstrdup(r->pool, r->uri);
-        rewritelog((r, 2, "init rewrite engine with requested uri %s",
-                    r->filename));
+        rewritelog(r, 2, "init rewrite engine with requested uri %s",
+                   r->filename);
     }
 
     /*

Mime
View raw message