httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: mod_deflate.c problems
Date Sat, 09 Oct 2004 09:54:34 GMT
On Fri, Oct 08, 2004 at 08:50:19AM -0700, Justin Erenkrantz wrote:
> --On Friday, October 8, 2004 3:59 PM +0100 Joe Orton <jorton@redhat.com> 
> wrote:
> 
> >zutil.h isn't really needed at all; in fact whole the gzip header could
> >be in an immortal bucket, much less overhead than jumping through the
> >psprintf code.  Try this?
> 
> I think we tried to hard-code OS_CODE to 0x03 initially and ran into some 
> type of portability problem.  That's why we were trying to set it 
> 'correctly.' Either way, it could still be an immortal bucket - that part 
> of your change is probably goodness.

I guess I can see there would have been problems from assuming zutil.h
exists and OS_CODE was defined, hence the current code, but it's hard to
imagine there are portability problems from just not using the things at
all... 

> 
> Jean-Frederic's problem just appears to be a warning because his install is 
> corrupt somehow.  It looks like he has conflicting zlib installations - so 
> I'd also expect the linker to get confused as well.  -- justin

It's apparently an issue when you have zlib 1.2.1 installed somewhere,
since in that version zutil.h is considered an "internal" header and is
not installed by make install:

http://issues.apache.org/bugzilla/show_bug.cgi?id=28673

so that's a good motivation for not using it too.

joe

Mime
View raw message