Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (hermes.apache.org: domain of trawick@gmail.com designates
 64.233.170.205 as permitted sender)
Message-ID: <cc67648e040918035256948a8d@mail.gmail.com>
Date: Sat, 18 Sep 2004 06:52:41 -0400
From: Jeff Trawick <trawick@gmail.com>
Reply-To: Jeff Trawick <trawick@gmail.com>
To: dev@httpd.apache.org
Subject: Re: [PATCH] don't crash with per-dir (location) rewrite config and
 NULL r->filename
In-Reply-To: <4141B26F.9010209@modperlcookbook.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
References: <cc67648e0409091041bf5a50c@mail.gmail.com>
	 <41419BBE.10600@modperlcookbook.org>
	 <41419DCD.7050209@modperlcookbook.org>
	 <cc67648e0409100542627f68bf@mail.gmail.com>
	 <4141B26F.9010209@modperlcookbook.org>

On Fri, 10 Sep 2004 09:55:59 -0400, Geoffrey Young
<geoff@modperlcookbook.org> wrote:
> 
> > I'm afraid I don't understand.
> 
> yeah, I'm sorry, that's my fault :)  I should have taken the time to analyze
> the code in context and follow it all through.
> 
> having done that, the only thing that comes to mind is I wonder how much
> logic can be skipped if r->filename is NULL and you assign it r->uri.  for
> instance,
> 
>         if (l > 6 && strncmp(r->filename, "proxy:", 6) == 0) {
>             /* it should go on as an internal proxy request */

the reason to fill in r->filename when I did was so that
apply_rewrite_list() has that info; otherwise, it will segfault (on
machines that don't like strlen(NULL)) or simply not match