Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 61361 invoked from network); 14 Sep 2004 17:22:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 14 Sep 2004 17:22:34 -0000 Received: (qmail 91561 invoked by uid 500); 14 Sep 2004 17:22:03 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 91498 invoked by uid 500); 14 Sep 2004 17:22:02 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 91441 invoked by uid 99); 14 Sep 2004 17:22:00 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: local policy) Received: from [82.193.192.5] (HELO pop.xnet.hr) (82.193.192.5) by apache.org (qpsmtpd/0.28) with ESMTP; Tue, 14 Sep 2004 10:21:59 -0700 Received: from [192.168.0.164] (dh205-166.xnet.hr [82.193.205.166]) by pop.xnet.hr (8.12.10/8.12.10) with ESMTP id i8EHNgRQ032498 for ; Tue, 14 Sep 2004 19:23:42 +0200 Message-ID: <414728AA.8030101@apache.org> Date: Tue, 14 Sep 2004 19:21:46 +0200 From: Mladen Turk User-Agent: Mozilla Thunderbird 0.7.3 (Windows/) X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: cvs commit: httpd-2.0/modules/proxy proxy_ajp.c References: <20040909195631.54780.qmail@minotaur.apache.org> <20040914171209.GA13468@redhat.com> In-Reply-To: <20040914171209.GA13468@redhat.com> Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=sha1; boundary="------------ms020701050603090105030301" X-Virus-Scanned: clamd / ClamAV version 0.71, clamav-milter version 0.71 X-Virus-Status: Clean X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N This is a cryptographically signed message in MIME format. --------------ms020701050603090105030301 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Joe Orton wrote: > On Thu, Sep 09, 2004 at 07:56:31PM -0000, mturk@apache.org wrote: > >>mturk 2004/09/09 12:56:31 >> >> Modified: modules/proxy proxy_ajp.c >> Log: >> Add function protos so that -Wmissing-declarations doesn't complain. > > > Adding separate declarations within a .c file (rater than a header) to > fix such warnings is rarely correct: it looks like these should just be > made static? (in which case, no separate declaration is needed) > Well, yes. It was just a copy/paste of the style used in the original code present for years inside proxy_http :). But you are correct, those are module private and should be static, both inside proxy_ajp and proxy_http. Regards, MT. --------------ms020701050603090105030301 Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIII5TCC As0wggI2oAMCAQICAwzTdDANBgkqhkiG9w0BAQQFADBiMQswCQYDVQQGEwJaQTElMCMGA1UE ChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNv bmFsIEZyZWVtYWlsIElzc3VpbmcgQ0EwHhcNMDQwODA4MTMxMzEwWhcNMDUwODA4MTMxMzEw WjBCMR8wHQYDVQQDExZUaGF3dGUgRnJlZW1haWwgTWVtYmVyMR8wHQYJKoZIhvcNAQkBFhBt dHVya0BhcGFjaGUub3JnMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAwtmY7tJD oBrtLUvsv/zgj1hHNxOjkJ7gurUI5zKaaTRtFGDTCJOeck2yl00MmBnJsiGbj3xF2YbMr5CI 4IBoV9dI76u4fBCx79KHa9lvtHGMJUGhLj68h87J8LGOpEyahuSvcx0BZIQJblXRaSF+eOXZ dxNX3HNCLOcjWWP7plS4HLVAS543jZW1ct7E2fYn6WbT1KGdxjjf5JLkY23O92LiJzPp48I8 HFOutSjQdPzAuVNMapjbwsg+2/UvfHiPguir1LFzN0sS9aM88h7quBIRMjcGluB/RKPC/4UL OeTvwNHRRw7jo7kVJeYA2C/SC7cEjbV0aWpdgOlLqYfoFQIDAQABoy0wKzAbBgNVHREEFDAS gRBtdHVya0BhcGFjaGUub3JnMAwGA1UdEwEB/wQCMAAwDQYJKoZIhvcNAQEEBQADgYEAmnd3 FdKPwup3SOaipz1VaMJP4H38VhNgbv56rCgjSW8n5EGiysio8GOEGKP/2MZO8Uz3urKxZ/qX B/mBg/K0w5Lr11ZcZqjiee+fLhQybWXTZkJMWij6vZzejJbPZmuPn7d0TM3ucLJIJSEDUdVs sXUPk32j+HsSuw9p58KSotUwggLNMIICNqADAgECAgMM03QwDQYJKoZIhvcNAQEEBQAwYjEL MAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAq BgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA0MDgwODEz MTMxMFoXDTA1MDgwODEzMTMxMFowQjEfMB0GA1UEAxMWVGhhd3RlIEZyZWVtYWlsIE1lbWJl cjEfMB0GCSqGSIb3DQEJARYQbXR1cmtAYXBhY2hlLm9yZzCCASIwDQYJKoZIhvcNAQEBBQAD ggEPADCCAQoCggEBAMLZmO7SQ6Aa7S1L7L/84I9YRzcTo5Ce4Lq1COcymmk0bRRg0wiTnnJN spdNDJgZybIhm498RdmGzK+QiOCAaFfXSO+ruHwQse/Sh2vZb7RxjCVBoS4+vIfOyfCxjqRM mobkr3MdAWSECW5V0Wkhfnjl2XcTV9xzQiznI1lj+6ZUuBy1QEueN42VtXLexNn2J+lm09Sh ncY43+SS5GNtzvdi4icz6ePCPBxTrrUo0HT8wLlTTGqY28LIPtv1L3x4j4Loq9SxczdLEvWj PPIe6rgSETI3Bpbgf0Sjwv+FCznk78DR0UcO46O5FSXmANgv0gu3BI21dGlqXYDpS6mH6BUC AwEAAaMtMCswGwYDVR0RBBQwEoEQbXR1cmtAYXBhY2hlLm9yZzAMBgNVHRMBAf8EAjAAMA0G CSqGSIb3DQEBBAUAA4GBAJp3dxXSj8Lqd0jmoqc9VWjCT+B9/FYTYG7+eqwoI0lvJ+RBosrI qPBjhBij/9jGTvFM97qysWf6lwf5gYPytMOS69dWXGao4nnvny4UMm1l02ZCTFoo+r2c3oyW z2Zrj5+3dEzN7nCySCUhA1HVbLF1D5N9o/h7ErsPaefCkqLVMIIDPzCCAqigAwIBAgIBDTAN BgkqhkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkExFTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTES MBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3dGUgQ29uc3VsdGluZzEoMCYGA1UE CxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lvbjEkMCIGA1UEAxMbVGhhd3RlIFBl cnNvbmFsIEZyZWVtYWlsIENBMSswKQYJKoZIhvcNAQkBFhxwZXJzb25hbC1mcmVlbWFpbEB0 aGF3dGUuY29tMB4XDTAzMDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVowYjELMAkGA1UEBhMC WkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1Ro YXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMIGfMA0GCSqGSIb3DQEBAQUAA4GN ADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU5VAK MNcCY1osiRVwjt3J8CuFWqo/cVbLrzwLB+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTX p6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZcmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYB Af8CAQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2NybC50aGF3dGUuY29tL1RoYXd0ZVBl cnNvbmFsRnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkGA1UdEQQiMCCkHjAcMRowGAYD VQQDExFQcml2YXRlTGFiZWwyLTEzODANBgkqhkiG9w0BAQUFAAOBgQBIjNFQg+oLLswNo2as Zw9/r6y+whehQ5aUnX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoLgnSe JVCUYsfbJ3FXJY3dqZw5jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHT HUb/XV9lTzGCAzswggM3AgEBMGkwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBD b25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFp bCBJc3N1aW5nIENBAgMM03QwCQYFKw4DAhoFAKCCAacwGAYJKoZIhvcNAQkDMQsGCSqGSIb3 DQEHATAcBgkqhkiG9w0BCQUxDxcNMDQwOTE0MTcyMTQ2WjAjBgkqhkiG9w0BCQQxFgQU+lg6 dA8iA0LpAi8hTBHg/p03X2UwUgYJKoZIhvcNAQkPMUUwQzAKBggqhkiG9w0DBzAOBggqhkiG 9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAgcwDQYIKoZIhvcNAwICASgweAYJKwYB BAGCNxAEMWswaTBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3RlIENvbnN1bHRpbmcg KFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIElzc3Vpbmcg Q0ECAwzTdDB6BgsqhkiG9w0BCRACCzFroGkwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRo YXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBG cmVlbWFpbCBJc3N1aW5nIENBAgMM03QwDQYJKoZIhvcNAQEBBQAEggEAs6laOuNoXi80nbE1 8muhS0mBOtS/CAJBdBi7SN36tFzdICb6rOKI6SHm8p+Pl3uWZsMr8Llqniq6w4vBrNXfFtp8 mqDzLhkwq70QTgA1B43mHXCnn2rUxLWml2P7Jb7e1dVxzPFJt2aN6TnzUe4DeF1FWmjL2eqn xYC7bDopEasTVeMt6Ubj7vlVkc8Bng0GfzgkMFmHrVQ9rzOyU7uozAJP3xsYYxIo2nMXrZNQ 8aNfS7fKf62RvDyzN5l/bbmReqCOZ0so7+GvVSmRtDq0NejM5O+xwBnHCBICEww9OkXig5qG jp+bL+GqhdSEPnXxXEVewqwzEniYlTh7D9+5IwAAAAAAAA== --------------ms020701050603090105030301--