httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: [PATCH] don't crash with per-dir (location) rewrite config and NULL r->filename
Date Sat, 18 Sep 2004 10:52:41 GMT
On Fri, 10 Sep 2004 09:55:59 -0400, Geoffrey Young
<geoff@modperlcookbook.org> wrote:
> 
> > I'm afraid I don't understand.
> 
> yeah, I'm sorry, that's my fault :)  I should have taken the time to analyze
> the code in context and follow it all through.
> 
> having done that, the only thing that comes to mind is I wonder how much
> logic can be skipped if r->filename is NULL and you assign it r->uri.  for
> instance,
> 
>         if (l > 6 && strncmp(r->filename, "proxy:", 6) == 0) {
>             /* it should go on as an internal proxy request */

the reason to fill in r->filename when I did was so that
apply_rewrite_list() has that info; otherwise, it will segfault (on
machines that don't like strlen(NULL)) or simply not match

Mime
View raw message