httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: [PATCH] don't crash with per-dir (location) rewrite config and NULL r->filename
Date Fri, 10 Sep 2004 18:11:47 GMT
On Fri, 10 Sep 2004 09:01:48 -0500, William A. Rowe, Jr.
<wrowe@rowe-clan.net> wrote:
> At 05:24 AM 9/10/2004, Jeff Trawick wrote:
> >On Fri, 10 Sep 2004 09:34:14 +0200, jean-frederic clere
> ><jfrederic.clere@fujitsu-siemens.com> wrote:
> >> Jeff Trawick wrote:
> >> > See attached patch.  Given a module with map-to-storage hook which
> >> > leaves r->filename NULL, and config like the following, you get
> >> > segfault on platforms that don't like strlen(NULL).
> >> >
> >> > <Location /silly/foo>
> >> > RewriteEngine On
> >> > RewriteCond %{SERVER_PORT} ^8080$
> >> > RewriteRule (.*) https://%{SERVER_NAME}%{REQUEST_URI}
> >> > </Location>
> >> >
> >> > /silly is handled by a module which implements a map-to-storage hook
> >> > and leaves r->filename NULL
> 
> That's fine - why aren't we detecting that this is a proxy request,
> and dropping out at proxy's map-to-storage hook???

it isn't a proxy request

> >> Why not returning DECLINED when r->filename is NULL?
> 
> +1, this would be much kinder behavior than a segfault.

no, still busted; obviously we can't segfault, but no reason for
<Location > directives not to apply to this request

> >The Location container takes effect even though r->filename is NULL
> >(there is no file representing the request), so I want the rewriterule
> >to be able to perform the redirection.
> 
> But that means the module must implement map_to_storage quicker than
> AP_HOOK_LAST, so this flavor of request is caught.

caught by which code?  I don't follow you here

Mime
View raw message