httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: [PATCH] don't crash with per-dir (location) rewrite config and NULL r->filename
Date Fri, 10 Sep 2004 12:42:17 GMT
On Fri, 10 Sep 2004 08:27:57 -0400, Geoffrey Young
<geoff@modperlcookbook.org> wrote:
> 
> >>odd to me that rewrite's translate_name hook, used for processing
> >>server config directives, can update r->filename permanently even when
> >>it declines
> >
> >
> > that's a common idiom for we mod_perl people :)
> 
> actually, I take that back (not enough coffee yet) - we do that with r->uri
> (like everyone else) but not r->filename.  eesh.
> 
> which makes me all the more curious why you would need that here.

I'm afraid I don't understand.

You're curious why my patch leaves r->filename in the same state that
it was on entry if the fixup hook DECLINEs?
or
You're curious (like me) why the translate name hook can leave
r->filename in a different state if it DECLINEs?
or
(something else)

Mime
View raw message