httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <jwool...@virginia.edu>
Subject Re: [PATCH] APR_BUCKET_INSERT_BEFORE in mod_logio.c
Date Tue, 21 Sep 2004 05:45:32 GMT
On Mon, 20 Sep 2004, Joe Schaefer wrote:

> Pretty much all the @warning sections that begin with
> "This doesn't work...", i.e.
>
> /**
>  * Insert the element nep into the ring before element lep
>  *   (..lep.. becomes ..nep..lep..)
>  * @warning This doesn't work for inserting before the first element or on
>  *   empty rings... see APR_RING_INSERT_HEAD for one that does
>  * @param lep  Element in the ring to insert before
>  * @param nep  Element to insert
>  * @param link The name of the APR_RING_ENTRY in the element struct
>  */
> #define APR_RING_INSERT_BEFORE(lep, nep, link)				\
> 	APR_RING_SPLICE_BEFORE((lep), (nep), (nep), link)


Hmm, okay.  That warning only applies to certain kinds of rings -- namely
rings where the offset between the value of the pointer to the head
structure and the value used as the sentinel is nonzero.  Brigades don't
fall into that category.  I've never even really seen the point for having
such a beast at all, actually.  So yeah, the warning could be more
specific, but it does apply in general to rings even though not to the
specific type of rings used by the bucket brigades.

--Cliff

Mime
View raw message