httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Stoddard <b...@wstoddard.com>
Subject Re: cvs commit: httpd-2.0/modules/experimental cache_storage.c cache_util.c mod_cache.c mod_cache.h mod_disk_cache.c mod_mem_cache.c
Date Fri, 24 Sep 2004 12:57:28 GMT
Justin Erenkrantz wrote:
> --On Thursday, September 23, 2004 8:17 PM -0400 Bill Stoddard 
> <bill@wstoddard.com> wrote:
> 
>> Justin Erenkrantz wrote:
>>
>>>> This little gem causes a regression. Because cache->handle is left 
>>>> NULL,
>>>> we never cleanup stale entries in the cache (in cache_save_filter). 
>>>> Once
>>>> CacheMaxExpires hits, the stale entry will never be garbage collected
>>>> from the cache and replaced by a new entry.  Two ways to fix this come
>>>> to mind right off hand (neither are optimal i expect):
>>>
>>>
>>>
>>> Well, I don't know about mod_mem_cache, but I don't believe this affects
>>> mod_disk_cache.  mod_disk_cache overwrites the old entry if it is told
>>> to do so.  It's possible that mod_mem_cache should do the same.
>>
>>
>> Will investigate.
> 
> 
> Upon looking into what mod_mem_cache does, I think your first patch is 
> the 'right' way to do this.  So, I committed it.
> 
> Lemme know how that fares.  -- justin
> 

Yep, I came to the same conclusion. Looks good. BTW Justin, nice patch (the big one I am about
to port to 
2.0), cleans up some crufty code paths nicely.

Bill

Mime
View raw message