httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Ames <grega...@remulak.net>
Subject Re: [PATCH] Re: Seg fault: race conditions in mod_mem_cache.c
Date Thu, 16 Sep 2004 15:50:46 GMT
Bill Stoddard wrote:

> -    /* If obj->complete is not set, the cache update failed and the
> -     * object needs to be removed from the cache then cleaned up.
> -     */
> -    if (!obj->complete) {
> -        if (sconf->lock) {
> -            apr_thread_mutex_lock(sconf->lock);
> -        }
> -        /* Remember, objects marked for cleanup are, by design, already
> -         * removed from the cache. remove_url() could have already
> -         * removed the object from the cache (and set obj->cleanup)
> -         */
> -        if (!obj->cleanup) {
> -            cache_remove(sconf->cache_cache, obj);
> -            obj->cleanup = 1;
> -        }
> -        if (sconf->lock) {
> -            apr_thread_mutex_unlock(sconf->lock);
> -        }
> -    }
> -

I don't understand why the equivalent of this section is no longer needed.  Was 
this dead code before?

Greg


Mime
View raw message