httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: cvs commit: httpd-2.0/modules/proxy proxy_ajp.c
Date Tue, 14 Sep 2004 17:21:46 GMT
Joe Orton wrote:
> On Thu, Sep 09, 2004 at 07:56:31PM -0000, mturk@apache.org wrote:
> 
>>mturk       2004/09/09 12:56:31
>>
>>  Modified:    modules/proxy proxy_ajp.c
>>  Log:
>>  Add function protos so that -Wmissing-declarations doesn't complain.
> 
> 
> Adding separate declarations within a .c file (rater than a header) to
> fix such warnings is rarely correct: it looks like these should just be
> made static? (in which case, no separate declaration is needed)
> 

Well, yes.
It was just a copy/paste of the style used in the original code
present for years inside proxy_http :).
But you are correct, those are module private and should be static,
both inside proxy_ajp and proxy_http.

Regards,
MT.

Mime
View raw message