httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jean-frederic clere <jfrederic.cl...@fujitsu-siemens.com>
Subject Re: [PATCH] don't crash with per-dir (location) rewrite config and NULL r->filename
Date Fri, 10 Sep 2004 07:34:14 GMT
Jeff Trawick wrote:
> See attached patch.  Given a module with map-to-storage hook which
> leaves r->filename NULL, and config like the following, you get
> segfault on platforms that don't like strlen(NULL).
> 
> <Location /silly/foo>
> RewriteEngine On
> RewriteCond %{SERVER_PORT} ^8080$
> RewriteRule (.*) https://%{SERVER_NAME}%{REQUEST_URI}
> </Location>
> 
> /silly is handled by a module which implements a map-to-storage hook
> and leaves r->filename NULL

Why not returning DECLINED when r->filename is NULL?

> 
> comments?  better way to do it?
> 
> odd to me that rewrite's translate_name hook, used for processing
> server config directives, can update r->filename permanently even when
> it declines


Mime
View raw message