httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <>
Subject Re: cvs commit: apr/network_io/win32 sendrecv.c
Date Thu, 23 Sep 2004 19:53:50 GMT
On Thu, Sep 23, 2004 at 03:37:01PM -0400, Allan Edwards wrote:
> The general approach I have been taking is changing locally declared
> int's to apr_size_t where feasible but I have avoided changing int's
> to apr_size_t in public structures.
> Changing public structures may ripple through other code
> and brings up concerns about MMN bumps. In this case we
> would incur a major bump I believe. Unless a particular
> field is resulting in warnings in multiple parts of the code
> I'm generally going to opt for the cast.

Yeah, but this is HEAD, so breaking the module ABI is OK.  I think it
would definitely be a good thing to fix the types properly on HEAD even
in public structures.


View raw message