httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] fix child reclaim timing
Date Wed, 15 Sep 2004 18:49:22 GMT
On Wed, Sep 15, 2004 at 01:48:11PM -0400, Jeff Trawick wrote:
> Here's a patch that does something like I mentioned above, though it
> bails out a bit sooner (9 or so seconds).  The timing of the
> interesting actions in this patch can be tweaked in a much simpler
> manner than the old 1.3 code allows.

Looks just as good to me, +1

> -         */
> +    while (1) {
>          apr_sleep(waittime);
...
> -        if (!not_dead_yet) {
> -            /* nothing left to wait for */
> +        if (!not_dead_yet ||
> +            action_table[cur_action].action == GIVEUP) {
> +            /* nothing left to wait for, or we gave up */
>              break;
>          }
>      }

...is crying out to be a do/while :)


Mime
View raw message