Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 90137 invoked from network); 14 Aug 2004 15:42:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 14 Aug 2004 15:42:14 -0000 Received: (qmail 58130 invoked by uid 500); 14 Aug 2004 15:42:10 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 57844 invoked by uid 500); 14 Aug 2004 15:42:08 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 57831 invoked by uid 99); 14 Aug 2004 15:42:08 -0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received: from [80.91.224.249] (HELO main.gmane.org) (80.91.224.249) by apache.org (qpsmtpd/0.27.1) with ESMTP; Sat, 14 Aug 2004 08:42:07 -0700 Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1Bw0fS-0008Cx-00 for ; Sat, 14 Aug 2004 17:42:03 +0200 Received: from adsl-34-76-42.mia.bellsouth.net ([67.34.76.42]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 14 Aug 2004 17:42:02 +0200 Received: from joe+gmane by adsl-34-76-42.mia.bellsouth.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 14 Aug 2004 17:42:02 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: dev@httpd.apache.org To: dev@httpd.apache.org From: Joe Schaefer Subject: Re: RFE: ap_input_mode_t as bitflags Date: 14 Aug 2004 11:41:59 -0400 Lines: 41 Message-ID: <87k6w1loag.fsf@gemini.sunstarsys.com> References: <20040811211646.GA12727@netspace.org> <2279233FA75D61F5583C9654@2B9FC815C12CF19931FDCE0B> <20040812065113.GA7112@netspace.org> <2FFD340F622D50092F2DA1D8@guest221.lyra.org> <87ekmbat9x.fsf@gemini.sunstarsys.com> <20040813173157.GA19243@netspace.org> <871xiac2bt.fsf@gemini.sunstarsys.com> <20040813184952.GB24587@netspace.org> <87wu02amam.fsf@gemini.sunstarsys.com> <20040814010442.GA26071@netspace.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: adsl-34-76-42.mia.bellsouth.net Mail-Copies-To: never User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 Sender: news X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Glenn Strauss writes: [...] > This just occurred to me: why not promote HTTP_IN to be a > connection level filter, and add a buffer brigade to http_ctx_t? IIRC Bill Stoddard posted something like this about a year ago. He and Brian Pane also discussed inverting the input filter's control flow from pull to push (1-2 years ago), but I didn't follow their conversation closely. Let me see if I can at least dig up the threads... Subject: [PATCH] event driven read http://marc.theaimsgroup.com/?l=apache-httpd-dev&m=103470304216864&w=2 http://marc.theaimsgroup.com/?l=apache-httpd-dev&m=106343279912187&w=2 Subject: [PATCH] Move http header parsing into the http_input_filter http://marc.theaimsgroup.com/?l=apache-httpd-dev&m=104611092606896&w=2 > Not only would that handle the case above, but it would also > obviate the need for the ugly AP_MODE_EATCRLF because the > HTTP_IN filter would handle what is now done in check_pipeline_flush(). > > And if we remove folding ability from ap_rgetline_core(), (and > replace the one usage of folding in proxy_util.c), then we can > also get rid of AP_MODE_SPECULATIVE. > > Getting rid of AP_MODE_SPECULATIVE and AP_MODE_EATCRLF sounds to me > like moves in the right direction. What do you think? Sounds good to me, but I'm curious to know what Justin thinks about it. -- Joe Schaefer