Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Message-ID: <410E6140.7090901@wstoddard.com>
Date: Mon, 02 Aug 2004 11:44:00 -0400
From: Bill Stoddard <bill@wstoddard.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
 rv:1.7) Gecko/20040616
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: [PATCH] mod_cache fixes: #5
References: <40B25DBF8F84D316162D79F8@[10.0.1.74]>
 <410D0B83.9040100@wstoddard.com> <1252C4FF6DF4B2297E96D74F@[10.0.1.75]>
In-Reply-To: <1252C4FF6DF4B2297E96D74F@[10.0.1.75]>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Justin Erenkrantz wrote:

> --On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard 
> <bill@wstoddard.com> wrote:
> 
>> Too many changes in one patch. Break this up into multiple consumable 
>> in 15
>> minute patches and I'll review them.
> 
> 
> * modules/experimental/mod_cache.c: Delay no-store check until saving.
>  (It's a corner case with little benefit in the mainline.)

+1. one small style nit.. My mailer is wrapping the line so apologies...

> -    cache = (cache_request_rec *) 
> ap_get_module_config(r->request_config, &cache_module);
> +    cache = (cache_request_rec *) ap_get_module_config(r->request_config,
> +                                                       &cache_module);
>     if (!cache) {
> +        /* user likely configured CACHE_SAVE manually; they should 
> really use
> +         * mod_cache configuration to do that */

comment end delimiter needs to be moved to its own line.

>         cache = apr_pcalloc(r->pool, sizeof(cache_request_rec));
>         ap_set_module_config(r->request_config, &cache_module, cache);
>     }
>