httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: cvs commit: httpd-2.0/modules/proxy proxy_util.c
Date Fri, 13 Aug 2004 15:54:52 GMT
On Fri, 13 Aug 2004 10:07:27 -0500, William A. Rowe, Jr.
<wrowe@rowe-clan.net> wrote:
> At 07:20 AM 8/13/2004, trawick@apache.org wrote:
> >trawick     2004/08/13 05:20:53
> >
> >  Modified:    modules/proxy proxy_util.c
> >  Log:
> >  axe some unused variables and don't log an error code that
> >  hasn't been initialized
> 
> >  -            ap_log_error(APLOG_MARK, APLOG_ERR, rv, s,
> >  +            ap_log_error(APLOG_MARK, APLOG_ERR, 0, s,
> >                            "proxy: %s: disabled connection for (%s)",
> >                            proxy_function, worker->hostname);
> 
> Shouldn't that be APLOG_ERR|APLOG_NOERRNO if rv isn't passed?

no.  1.3 required APLOG_NOERRNO so that it didn't look at errno;

the natural logic of formatting the error information when the
apr_status_t parameter is non-APR_SUCCESS is what is used

APLOG_NOERRNO is still defined but has no effect

Mime
View raw message