httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject [PATCH] mod_cache: Use provider API
Date Wed, 04 Aug 2004 19:39:30 GMT
This patch removes the mod_cache dependencies upon the odd vtable and hooks 
and standardizes upon the ap_provider_* API.  mod_auth uses this provider 
interface now as has mod_dav.

Besides removing a bunch of code, this has a number of beneficial side-effects:

- All operations related to a cache are in *one* location/structure (yay!)
- Removal of some cache wrappers that shouldn't have been there.
- The remaining cache wrappers don't have to lookup/parse the 'type' string 
every time.  Instead, it can just walk the pre-built provider list.
- If a cache handler is invoked, instead of doing strcmp's to ensure it was 
meant to be called, they can just invoke - skipping these checks.
- The ordering still remains the same (first cache to have it wins).

I do have some code commented out that needs to be deleted entirely, but you 
can get the idea of the patch from this one.

FWIW, the caching directive syntax remains the same.  It's just an internal 
reorganization.  -- justin

Mime
View raw message