httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <>
Subject Re: RFE: ap_input_mode_t as bitflags
Date Sat, 14 Aug 2004 15:41:59 GMT
Glenn Strauss <> writes:


> This just occurred to me: why not promote HTTP_IN to be a
> connection level filter, and add a buffer brigade to http_ctx_t?

IIRC Bill Stoddard posted something like this about a year ago.
He and Brian Pane also discussed inverting the input filter's
control flow from pull to push (1-2 years ago), but I didn't 
follow their conversation closely.  Let me see if I can at least 
dig up the threads...

Subject: [PATCH] event driven read

Subject: [PATCH] Move http header parsing into the http_input_filter

> Not only would that handle the case above, but it would also
> obviate the need for the ugly AP_MODE_EATCRLF because the
> HTTP_IN filter would handle what is now done in check_pipeline_flush().
> And if we remove folding ability from ap_rgetline_core(), (and
> replace the one usage of folding in proxy_util.c), then we can
> also get rid of AP_MODE_SPECULATIVE.
> Getting rid of AP_MODE_SPECULATIVE and AP_MODE_EATCRLF sounds to me
> like moves in the right direction.  What do you think?

Sounds good to me, but I'm curious to know what Justin thinks 
about it.

Joe Schaefer

View raw message