httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: New Mod_Proxy - some testing/looking
Date Fri, 13 Aug 2004 03:03:34 GMT
Please direct these comments to dev@httpd.apache.org - b.t.w., you
can check out the latest httpd-2.0 HEAD and pick up the entire proxy
solution (you must explicitly --enable-proxy-ajp and have the ajplib
sources there too.)

Someone want to take a wack at NormW's observations?

At 02:31 AM 8/11/2004, NormW wrote:
>Greetings All,
>
>1. The testing.
>
>Trying a build of the current CVS of the new (ajp) proxy modules and get the
>following error:
>
>#    File: proxy_ftp.c
># --------------------
>#    1896: proxy_hook_scheme_handler(ap_proxy_ftp_handler, NULL, NULL,
>APR_HOOK_MIDDLE);
>#   Error:
>^
>#   illegal implicit conversion from 'int (struct request_rec *, struct  *,
>char *, const char *, unsigned short)' to
>#   'int (*)(struct request_rec *, struct proxy_worker *, struct  *, char *,
>const char *, unsigned short)'
>
>There is a similar issue in proxy_connect.c at line 374.
>
>The one module that does build without issue is proxy_http.c.
>
>A check of the coding in proxy_http.c shows a handler structure of:
>int ap_proxy_http_handler(request_rec *r,
>                          proxy_worker *worker,
>                          proxy_server_conf *conf,
>                          char *url,
>                          const char *proxyname,
>                          apr_port_t proxyport);
>
>whereas those in proxy_ftp and proxy_connect.c have:
>int ap_proxy_ftp_handler(request_rec *r,
>                             proxy_server_conf *conf,
>                             char *url,
>                             const char *proxyhost,
>                             apr_port_t proxyport);
>
>
>If I add the "proxy_worker *worker" to both proxy_ftp and proxy_connect
>structures they build without issue.
>Any comments please?
>
>2. The looking.
>
>In proxy_ftp.c, can the "const char *proxyhost" be changed to "const char
>*proxyname" for consistency please?
>
>Regards,
>Norm
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org



Mime
View raw message