httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Stoddard <b...@wstoddard.com>
Subject Re: [PATCH] mod_disk cached fixed
Date Wed, 04 Aug 2004 20:32:34 GMT
Brian Akins wrote:

> Should this:
>   cache_in_filter_handle =
>        ap_register_output_filter("CACHE_IN",
>                                  cache_in_filter,
>                                  NULL,
>                                  AP_FTYPE_CONTENT_SET-1);
> 
> 
> 
> Actually be this:
> 
> cache_in_filter_handle =
>        ap_register_output_filter("CACHE_IN",
>                                  cache_in_filter,
>                                  NULL,
>                                  AP_FTYPE_CONTENT_SET+1);
> 
> 
> 
> Notice the plus in the second.
> 
> 
This is the area in which mod_cache is most broken. It does not handle vary at all, thus the
content needs to 
be stored before it is touched by any filters. But that doesn't work either because some filters
will not 
properly run when serving content out of a quick_handler (ie, they might rely on some special
something 
happening in the fixups hook for instance). Can't recall any exact scenarios right off the
top of my busy 
brain but I know they exist. Would be real good to get this fixed in 2.2

Bill

Mime
View raw message