httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Stoddard <b...@wstoddard.com>
Subject Re: [PATCH] mod_cache fixes: #3
Date Mon, 02 Aug 2004 17:05:05 GMT
Justin Erenkrantz wrote:

> --On Monday, August 2, 2004 10:35 AM -0400 Bill Stoddard 
> <bill@wstoddard.com> wrote:
> 
>>> * modules/experimental/mod_disk_cache.c: Allow sendfile on cache bodies.
>>>
>>
>> -1, Need to check for EnableSendfile off.
> 
> 
> No, core_output_filter does that check.  Modules don't have that 
> information whether EnableSendfile is on or not.  Only the 'core' does.  
> -- justin
> 

I should amend my vote a -.5. The patch should work as you've coded it but opening a file
for use with 
apr_sendfile causes the file to be opened for overlapped i/o on Windows.  I expect some of
the codepaths will 
not correctly handle this (Jeff and I fixed one such case when a file was opened for sendfile
but mod_ssl 
prevented apr_sendfile from actually being used). Probably more bugs but they need to be found
and fixed and I 
have no idea if there are other similar issues on platforms other than windows.

Bill

Mime
View raw message