httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Stoddard <b...@wstoddard.com>
Subject Re: [PATCH] mod_cache fixes: #5
Date Mon, 02 Aug 2004 15:44:00 GMT
Justin Erenkrantz wrote:

> --On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard 
> <bill@wstoddard.com> wrote:
> 
>> Too many changes in one patch. Break this up into multiple consumable 
>> in 15
>> minute patches and I'll review them.
> 
> 
> * modules/experimental/mod_cache.c: Delay no-store check until saving.
>  (It's a corner case with little benefit in the mainline.)

+1. one small style nit.. My mailer is wrapping the line so apologies...

> -    cache = (cache_request_rec *) 
> ap_get_module_config(r->request_config, &cache_module);
> +    cache = (cache_request_rec *) ap_get_module_config(r->request_config,
> +                                                       &cache_module);
>     if (!cache) {
> +        /* user likely configured CACHE_SAVE manually; they should 
> really use
> +         * mod_cache configuration to do that */

comment end delimiter needs to be moved to its own line.

>         cache = apr_pcalloc(r->pool, sizeof(cache_request_rec));
>         ap_set_module_config(r->request_config, &cache_module, cache);
>     }
> 


Mime
View raw message