httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: cvs commit: httpd-2.0 STATUS
Date Thu, 29 Jul 2004 03:53:58 GMT
At 05:55 PM 7/28/2004, minfrin@apache.org wrote:
>minfrin     2004/07/28 15:55:15
>
>  Modified:    .        Tag: APACHE_2_0_BRANCH STATUS
>  Log:
>  Propose a backport
>  
>  +    *) Add load balancer support to the scoreboard in preparation for
>  +       load balancing support in mod_proxy.
>  +         include/scoreboard.h: 1.52
>  +         server/scoreboard.c: 1.75
>  +       +1: minfrin

Rather than vote... afraid I have to veto (for 2.0)...

>  --- scoreboard.h      9 Feb 2004 20:38:21 -0000       1.51
>  +++ scoreboard.h      28 Jul 2004 22:50:54 -0000      1.52
>  @@ -32,6 +32,7 @@
>   #include "apr_thread_proc.h"
>   #include "apr_portable.h"
>   #include "apr_shm.h"
>  +#include "apr_optional.h"
>   
>   /* Scoreboard file, if there is one */
>   #ifndef DEFAULT_SCOREBOARD
>  @@ -118,6 +119,7 @@
>   typedef struct {
>       int             server_limit;
>       int             thread_limit;
>  +    int             lb_limit;
>       ap_scoreboard_e sb_type;
>       ap_generation_t running_generation;      /* the generation of children which
>                                            * should still be serving requests. */

This definitely breaks binary compatibility.

Bill  


Mime
View raw message