httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <>
Subject ap_meets_conditions doc: bogus return value?
Date Sat, 17 Jul 2004 04:48:23 GMT
  * Implements condition GET rules for HTTP/1.1 specification.  This 
  * inspects the client headers and determines if the response fulfills
  * the requirements specified.
  * @param r The current request
  * @return 1 if the response fulfills the condition GET rules, 0 otherwise
  * @deffunc int ap_meets_conditions(request_rec *r)
AP_DECLARE(int) ap_meets_conditions(request_rec *r);

The @return value seems to be totally bogus, the function returns OK (0) 
if the conditions were met (not 1), otherwise it returns either of these 

#define HTTP_PRECONDITION_FAILED           412
#define HTTP_NOT_MODIFIED                  304

though since other constants may be returned later should the doc be 
something like the following:

  * @return OK if the response fulfills the condition GET rules, some 
other status code otherwise

Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker     mod_perl Guide --->

View raw message