Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Date: Sat, 5 Jun 2004 10:29:13 -0400 (Eastern Daylight Time)
From: Joshua Slive <joshua@slive.ca>
To: dev@httpd.apache.org
Subject: Re: Better error logging for mod_access
In-Reply-To: <40C1D64D.6080107@attglobal.net>
Message-ID: <Pine.WNT.4.58.0406051024120.2548@bronfman504>
References: <1086444535.40c1d3f78e08b@correo.speedy.com.pe>
 <40C1D64D.6080107@attglobal.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII


On Sat, 5 Jun 2004, Jeff Trawick wrote:

> ricilake@speedy.com.pe wrote:
>
> > The patch here: <http://drbacchus.com/files/access_logging_patch.txt> for
> > 2.0.49 creates logs that look like this:
> >
> > [Fri May 28 22:19:16 2004] [notice] Apache/2.0.49 (Unix) configured --
> > resuming
> > normal operations
> > [Fri May 28 22:19:24 2004] [error] [client 192.168.1.33] client denied by
> > order directive at line 362 of /opt/apache2/conf/httpd.conf for:
> > /opt/apache2/htdocs/bar
>
> What about enabling via a per-dir directive?  Looks very useful, but some sites
>   might have a significant number of new entries in error log serving no useful
> purpose (for them).

The problem with per-dir is that the user might not know exactly where in
the config file he should be editting.  If they did, they probably
wouldn't have a problem finding the relevant allow/deny in the first
place.

What about keeping the old error message, but logging an *additional*
message at loglevel debug with the additional info?

Two other notes:
- Personally, I hate arbitrary path-size limitations.  They always bite
you when you least expect it.  What about dynamically sizing this?
- You'll get more people to read your patches if you use "diff -u".

Joshua.