Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 16638 invoked from network); 15 Jun 2004 21:08:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 15 Jun 2004 21:08:39 -0000 Received: (qmail 4679 invoked by uid 500); 15 Jun 2004 21:08:51 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 4656 invoked by uid 500); 15 Jun 2004 21:08:50 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 4612 invoked by uid 99); 15 Jun 2004 21:08:50 -0000 Received: from [128.143.137.19] (HELO ares.cs.Virginia.EDU) (128.143.137.19) by apache.org (qpsmtpd/0.27.1) with ESMTP; Tue, 15 Jun 2004 14:08:50 -0700 Received: from cobra.cs.Virginia.EDU (cobra.cs.Virginia.EDU [128.143.137.16]) by ares.cs.Virginia.EDU (8.12.10/8.12.10/UVACS-2003031900) with ESMTP id i5FL8INU024453 for ; Tue, 15 Jun 2004 17:08:18 -0400 (EDT) Date: Tue, 15 Jun 2004 17:08:18 -0400 (EDT) From: Cliff Woolley X-X-Sender: jcw5q@cobra.cs.Virginia.EDU To: dev@httpd.apache.org Subject: Re: cvs commit: httpd-2.0/modules/echo mod_echo.c In-Reply-To: <20040615202717.95972.qmail@minotaur.apache.org> Message-ID: References: <20040615202717.95972.qmail@minotaur.apache.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N On Tue, 15 Jun 2004 jorton@apache.org wrote: > * modules/echo/mod_echo.c (process_echo_connection): Fix brigade > handling: don't re-use a passed brigade. Hang on.. why is the passed brigade getting destroyed? You're supposed to be able to reuse your brigades after the call stack has returned to you--that's why if a later filter wants to stash all the buckets in the brigade you've passed them, they have to create their own brigade to put them in. Brigade reuse is why there's a distinction between apr_brigade_cleanup() and apr_brigade_destroy()... sounds like there's a destroy somewhere that ought to be a cleanup. --Cliff