httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <jwool...@virginia.edu>
Subject Re: cvs commit: httpd-2.0/modules/echo mod_echo.c
Date Tue, 15 Jun 2004 21:08:18 GMT
On Tue, 15 Jun 2004 jorton@apache.org wrote:

>   * modules/echo/mod_echo.c (process_echo_connection): Fix brigade
>   handling: don't re-use a passed brigade.

Hang on.. why is the passed brigade getting destroyed?  You're supposed to
be able to reuse your brigades after the call stack has returned to
you--that's why if a later filter wants to stash all the buckets in the
brigade you've passed them, they have to create their own brigade to put
them in.

Brigade reuse is why there's a distinction between apr_brigade_cleanup()
and apr_brigade_destroy()... sounds like there's a destroy somewhere that
ought to be a cleanup.

--Cliff

Mime
View raw message