httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: httpd-2.0 STATUS
Date Sat, 12 Jun 2004 16:10:05 GMT
Joe Orton wrote:
> On Sat, Jun 12, 2004 at 09:54:56AM -0000, nd@apache.org wrote:
> 
>>  --- STATUS	11 Jun 2004 21:05:21 -0000	1.751.2.920
>>  +++ STATUS	12 Jun 2004 09:54:56 -0000	1.751.2.921
>>  @@ -74,8 +74,10 @@
>>   
>>       *) mod_ssl: Remove some unused functions (after CAN-2004-0488 fix is applied)
>>          http://cvs.apache.org/viewcvs.cgi/httpd-2.0/modules/ssl/ssl_util.c?r1=1.46&r2=1.47
>>  -       +1: jorton, nd
>>  +       +1: jorton
>>          trawick: need changes to mod_ssl.h to remove prototypes for those removed
functions
>>  +       -1: nd: actually that's a public API change (major bump) then and not
>>  +           applicable for 2.0, just let 'em in
> 
> 
> The entire contents of mod_ssl.h just cannot be considered a public API,
> that's too much, even the config structures are in there.  The only
> thing that's usable from other modules is the optional hook, and in
> reality that declaration just gets cut'n'pasted anyway (even by
> third-party modules I've seen).

Agreed.

Without the proper API wrapper (AP_DECLARE) a function may fail to be usable 
multiplatform anyway.  Anything without API wrappers should be considered 
implementation details.

We could issue an RFC on this issue with next stable release, stating how 
module authors can determine whether a callable function in an Apache header 
file is considered an API, and explaining our need to modify implementation 
details as necessary to keep the code base maintainable as we make fixes and 
enhancements. Any screaming could hopefully be converted into clear requests 
for certain interfaces to be considered APIs.

Mime
View raw message