httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: cvs commit: httpd-2.0/modules/ssl ssl_engine_vars.c
Date Tue, 29 Jun 2004 14:15:53 GMT
On Tue, Jun 29, 2004 at 10:11:44AM -0400, Jeff Trawick wrote:
> martin@apache.org wrote:
> >martin      2004/06/29 07:06:08
> >
> >  Modified:    modules/ssl ssl_engine_vars.c
> >  Log:
> >  Use the correct Apache-2.x EBCDIC conversion function (not the old 
> >  apache-1.3 routine)
> 
> >  -#ifdef CHARSET_EBCDIC
> >  -                    ascii2ebcdic(result, result, 
> >  -                                 X509_NAME_ENTRY_get_data_len(xsne));
> >  -#endif /* CHARSET_EBCDIC */
> >  +#if APR_CHARSET_EBCDIC
> >  +                    ap_xlate_proto_from_ascii(result, data_len);
> >  +#endif /* APR_CHARSET_EBCDIC */
> 
> no need to wrap this inside APR_CHARSET_EBCDIC; if no conversion necessary, 
> ap_xlate_proto_from_ascii is no-op macro

It also needs s/data_len/X509_NAME_ENTRY_get_data_len(xsne)/ to make it
compile.

joe

Mime
View raw message