On Tue, Jun 15, 2004 at 03:23:42PM +0100, Joe Orton wrote:
> http://issues.apache.org/bugzilla/show_bug.cgi?id=23567
OK, the issues I was having with using the bucket allocator to allocate
the brigade were just my own screwups. So, the patches needed to fix
this issue are attached:
1) re-use pool cleanup structures
2) allocate brigade structures using the bucket allocator
these combine to prevent unbounded memory consumption when using
apr_brigade_split() from an output filter.
(2) means that use of a brigade after it has been destroyed will now
result in a segfault. The test suite catches a particularly nice place,
which leads to:
3) don't destroy the brigade being flushed in ap_filter_flush; pass down
a temporary brigade.
(looks like mod_bucketeer is also screwed like this, still working on
that one)
Comments?
joe
|
| Mime |
- Unnamed multipart/mixed (inline, None, 0 bytes)
|