httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] RE: Regarding parse_byterange()
Date Fri, 30 Apr 2004 10:07:46 GMT
On Thu, Apr 29, 2004 at 09:43:34AM -0700, Mathihalli, Madhusudan wrote:
> >-----Original Message-----
> >From: Joe Orton [mailto:jorton@redhat.com]
> [SNIP]
> >
> >> What if the user really sent a
> >> large value for a small file ? Instead of erroring out - 
> >thanks to the
> >> overflow mechanism, we'll probably end up serving a sane result -
> >> Should we leave it that way ?
> >
> >Oh, good point, yes, it should definitely be fixed then.
> >
>
> How about the following patch ?

Looks fine, though it doesn't handle errors in apr_atoi64 itself so it
would be good to surround the calls with a single errno = 0 / ... / 
if (errno) return -1; check too.

joe

Mime
View raw message