httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <>
Subject Re: [PATCH] Candidate 1: Re: 1.3.3x digest/nonce issue
Date Fri, 16 Apr 2004 13:39:33 GMT
Jeff Trawick wrote:
> see my prior comment on that section of code ;)
> Dirk's later patch got rid of extra "%s" in the format string, so zap the last 
> "%s" as well as my lame "WHAT_THE_HECK_GOES_HERE?".

There was som discussion on making ServerName a semi-realm-based
aspect of the nonce... 

> Anybody want to think about what happens if we're so unlucky that the 
> ap_user_name or ap_pid_fname string with '\0' is smaller than sizeof(unsigned 
> long) and just happens to be allocated at the end of a page?  Unlikely, but 
> still...  Maybe those are supposed to be &ap_user_name, &ap_listeners, etc.?

In which case we could use our native '%pp' format (which we
should be doing anyway). From my read of it, I think that Dirk's
intent was to use the *addresses* of those parameters, so
yeah, I think that's not quite right.

   Jim Jagielski   [|]   [|]
      "A society that will trade a little liberty for a little order
             will lose both and deserve neither" - T.Jefferson

View raw message