Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Date: Sat, 13 Mar 2004 20:40:56 +0100
From: Guenter Knauf <eflash@gmx.net>
Reply-To: Guenter Knauf <eflash@gmx.net>
To: dev@httpd.apache.org
Subject: Re: [PATCH] mod_alias.c - add filename to log warning
Message-ID: <sos7DPbCYWPmmtRHAJPQBxUUI8GNJgmZOMitjnCWRVt@akmail>
References: <JGw4Uqk6CYaB5CvhUCoS1A8WzzAId51ez6BaHT2dJDK@akmail>
 <CF09C30C-719F-11D8-B93F-000A95CDA38A@asemantics.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

On Mar 9, 2004, at 9:00 AM, Dirk-Willem van Gulik wrote:

> On Mar 9, 2004, at 2:25 AM, Guenter Knauf wrote:

>> --- mod_alias.c.orig    Tue Feb 10 00:16:10 2004
>> +++ mod_alias.c         Mon Mar 08 22:06:20 2004
>> @@ -137,9 +137,10 @@
>>              if (  (!p->regexp &&  alias_matches(f, p->fake) > 0)
>>                  || (p->regexp && !ap_regexec(p->regexp, f, 0, NULL,
>> 0))) {
>>                  ap_log_error(APLOG_MARK, APLOG_WARNING, 0,
>> cmd->server,
>> -                             "The %s directive at line %d will
>> probably never "
>> +                             "The %s directive in %s at line %d will
>> probably never "
>>                               "match because it overlaps an earlier
>> %sAlias%s.",
>> -                             cmd->cmd->name, cmd->directive->line_num,
>> +                             cmd->cmd->name, cmd->directive->filename,
>> +                             cmd->directive->line_num,
>>                               p->handler ? "Script" : "",
>>                               p->regexp ? "Match" : "");
>>
> +1 - this has bitten me more than once.
me and a lot of users too;
can you perhaps commit it?

thanks, Guenter.