httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <bnicho...@novell.com>
Subject Re: cvs commit: httpd-2.0/modules/arch/netware mod_nw_ssl.c
Date Mon, 08 Mar 2004 01:18:47 GMT
  Including "mod_ssl.h" is probably the correct way that this should be
done although I was having some problems with the NetWare makefiles when
I started making this change.  I think I have it worked out now so I
should be able to include mod_ssl instead of duplicating the prototypes.
 As far as copy n' paste of the ssl_var_lookup() function, the NetWare
version isn't the same as the mod_ssl version.  To make it work I would
have had to #ifdef the code which isn't a good thing to do in a module. 
The serverconfig struct that NetWare uses isn't the same as the one that
mod_ssl uses and mod_nw_ssl is not able to get as much detailed
information about SSL because it is built into the NetWare OS (which is
the reason why mod_nw_ssl exists).

Brad

Brad Nicholes
Senior Software Engineer
Novell, Inc., the leading provider of Net business solutions
http://www.novell.com 

>>> jorton@redhat.com Sunday, March 07, 2004 11:46:33 AM >>>
On Sun, Mar 07, 2004 at 03:08:21AM -0000, bnicholes@apache.org wrote:
> bnicholes    2004/03/06 19:08:21
> 
>   Modified:    modules/arch/netware mod_nw_ssl.c
>   Log:
>   Add the ssl_is_https() and ssl_var_lookup() optional functions to
the  mod_nw_ssl module for Netware

If you intend mod_nw_ssl to be implement hooks which are compatible
with
mod_ssl, it should simply #include "mod_ssl.h" rather than
copy'n'pasting the hook declarations.  Copy'n'pasting all of
ssl_var_lookup is still very ugly :(

...
>   +/* The ssl_var_lookup() optional function retrieves SSL
environment
>   + * variables. */
>   +APR_DECLARE_OPTIONAL_FN(char *, ssl_var_lookup,
>   +                        (apr_pool_t *, server_rec *,
>   +                         conn_rec *, request_rec *,
>   +                         char *));
>   +
>   +/* An optional function which returns non-zero if the given
connection
>   + * is using SSL/TLS. */
>   +APR_DECLARE_OPTIONAL_FN(int, ssl_is_https, (conn_rec *));
>   +
>   +/* The ssl_proxy_enable() and ssl_engine_disable() optional
functions
>   + * are used by mod_proxy to enable use of SSL for outgoing
>   + * connections. */
>    APR_DECLARE_OPTIONAL_FN(int, ssl_proxy_enable, (conn_rec *));
>    APR_DECLARE_OPTIONAL_FN(int, ssl_engine_disable, (conn_rec *));


Mime
View raw message